IP filtering mitigation#1228
Merged
Merged
Conversation
1. Now only rules that have deny permissions already set will show up in IPsNotAdded 2. Updated the Warning message that is shown during apply mitigation and looged the IpsNotAdded in log file instead of prining it to console Bug fixes: 1. 255.255.255.255 entry getting added while rollback 2. extra True value getting added to the list of IPsNotAddded while applying mitigation 3. Apply mitigation fails with error duplicate ips found (some local ips getting duplicated) 4. fails to apply mitigation if duplicate ips are present in the ip list provided by user
…S-Exchange-Internal into guptavarun-V2script
…voke validate mitigation
…S-Exchange-Internal into guptavarun-V2script
… that are unchanged after applying mitigations
…S-Exchange-Internal into guptavarun-V2script
…S-Exchange-Internal into guptavarun-V2script
Extended Protection EWS mitigation
dpaulson45
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IP filtering mitigation to Extended Protection script